Upgrade minitest from 5.27.0 to 6.0.1 for supported Rails (8.1, main) #2491
+490
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larouxn
force-pushed
the
upgrade_to_minitest_6
branch
from
0c15ef8 to
8ac2f62
Compare
larouxn
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This upgrade is now possible because Rails 8.1.2 added support for Minitest 6. Even Rails 8.0.x now supports Minitest 6 but currently only in 8-0-stable branch as there hasn't been a release yet.
larouxn
force-pushed
the
upgrade_to_minitest_6
branch
from
8ac2f62 to
7dd6821
Compare
larouxn
changed the title
larouxn
changed the title
larouxn
changed the title
Author
|
Thanks for the CI run! Looking into the remaining failures, apparently only with Rails 8.1 (current). 🤔 |
- Add minitest-mock gem as it was split out from minitest core in minitest 6 - Update spec_helper.rb to conditionally require minitest/mock only for minitest 6 and above - Update spec_helper.rb to not require minitest-reporters for minitest 6 as it doesn't support minitest 6 yet
larouxn
changed the title
Author
|
Alrighty, I have some fixes for minitest 6 compatibility (e6f0167). Tested locally and only the protobuf spec fails, same 12 failures on both Rails 8.1 and Rails 8.0, and all other tests pass so likely cause is my machine. Additionally ran this branch through CI on my fork and everything passed, aside from 3 failures and 1 error on Rails main for all Ruby versions (example) re: Rails main being a moving target. (quick fix for reference) That said, ideally we wouldn't need so many conditionals. If we want to wait for the following so we don't, that's fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Came across this
gem "minitest", "< 6.0"lock inGemfileand decided to remove it because Rails has since added support for Minitest 6 in Rails 8.1.2 which we upgraded to in #2487. Even Rails 8.0.x now supports Minitest 6 but currently only in 8-0-stable branch as there hasn't been a release yet, hence the conditional.Follow up to #2458
References
Implementation
Deleted Minitest version lock and then
bundle update minitest --conservative. ᕕ( ᐛ )ᕗTests 🎩
Hit some errors. Maybe flake or perhaps an issue with my machine. Would like to see in CI.